Skip to content

[3.14] gh-132775: Use _PyCode GetScriptXIData() (gh-134511) #134515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

[3.14] gh-132775: Use _PyCode GetScriptXIData() (gh-134511) #134515

merged 1 commit into from
May 22, 2025

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 22, 2025 •
edited by bedevere-app bot
Loading

(cherry picked from commit 09e72cf)

Co-authored-by: Eric Snow [email protected]

@bedevere-app bedevere-app bot mentioned this pull request May 22, 2025
Closed
@bedevere-app bedevere-app bot mentioned this pull request May 22, 2025
Merged
@ericsnowcurrently ericsnowcurrently enabled auto-merge (squash) May 22, 2025 14:42
@ericsnowcurrently ericsnowcurrently merged commit bbf8048 into python:3.14 May 22, 2025
44 checks passed
@encukou
Copy link
Member

encukou commented May 23, 2025

Since this was merged, NoGIL refleaks buildbots show refleaks.

ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request May 23, 2025
@ericsnowcurrently
Revert "[3.14] pythongh-132775: Use _PyCode GetScriptXIData() (python…
250b775 
…gh-134515)"

This reverts commit bbf8048.
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 23, 2025
Merged
ericsnowcurrently added a commit that referenced this pull request May 23, 2025
@ericsnowcurrently
[3.14] gh-134557: Revert "[3.14] gh-132775: Use _PyCode GetScriptXIDa…
7476f90 
…ta()" (gh-134600)

This reverts commit bbf8048, AKA gh-134515.

We are reverting due to refleaks on free-threaded builds.
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 26, 2025
Merged
ericsnowcurrently added a commit that referenced this pull request May 26, 2025
@ericsnowcurrently
[3.14] gh-132775: Unrevert "Use _PyCode GetScriptXIData()" (gh-134736)
e86efab 
This reverts commit 7476f90, AKA gh-134600.

This effectively unreverts commit bbf8048 (gh-134515).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miss-islington @encukou @ericsnowcurrently